[py] Upgrade dependencies for mypy tox environment#15642
Merged
cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom Apr 19, 2025
Merged
[py] Upgrade dependencies for mypy tox environment#15642cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom
cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
This was referenced Sep 12, 2025
This was referenced Sep 19, 2025
This was referenced Oct 1, 2025
This was referenced Dec 21, 2025
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
This PR upgrades the dependencies for the
mypyenvironment inpy/tox.ini(this is what we use for type checking).This includes the latest versions of:
mypylxmltrio-typing(all other dependencies were already at the latest version)
The reason for this change is because the old version of
lxmlwould not build on Python 3.12 and 3.13, making it inconvenient to run locally. The new set of dependencies work correctly on all versions of Python we support (3.9 - 3.13).💡 Additional Considerations
This PR doesn't fix any of the 128 errors MyPy currently finds (this really needs some attention).
This PR shouldn't affect CI because we don't fail CI runs when the
Mypyworkflow job fails.The job runs:
... which returns
truewhen the job fails.🔄 Types of changes
PR Type
enhancement, other
Description
Upgraded
mypydependency to version 1.15.0.Updated
lxmldependency to version 5.3.2.Upgraded
trio-typingdependency to version 0.10.0.Ensured compatibility with Python versions 3.9 to 3.13.
Changes walkthrough 📝
tox.ini
Upgrade dependencies in `mypy` tox environmentpy/tox.ini
mypyversion from 1.4.1 to 1.15.0.lxmlversion from 4.9.1 to 5.3.2.trio-typingversion from 0.7.0 to 0.10.0.